Reference-fixes

[Nitin2332]

Resolves #8073

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[perminder-17]

Currently we have linting errors which says:

 Running "eslint:source" (eslint) task
/home/runner/work/p5.js/p5.js/src/color/setting.js:497:3: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/color/setting.js:1066:3: Trailing spaces not allowed. [Error/no-trailing-spaces]
Warning: ner/work/p5.js/p5.js/src/core/reference.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]
/home/runner/work/p5.js/p5.js/src/core/shape/vertex.js:1417:3: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/core/shape/vertex.js:1422:3: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/core/shape/vertex.js:1424:3: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/core/shape/vertex.js:1427:3: Trailing spaces not allowed. [Error/no-trailing-spaces]

Can you fix them?

[perminder-17]

Hi @Nitin2332 , I don't think your PR is currently fixing all the points mentioned on the PR.

The points currently are:

stroke() -- ...after calling stroke() will be outlined with the color orange...
fill() -- The version of fill() with four parameters... is missing
background() -- The version of background() with four parameters... is missing
endShape() -- Stops adding vertices to a custom shape.
shearY() -- In the example comments, // Shear the coordinate system along the **y**-axis.
applyMatrix() -- Broken link: https://en.wikipedia.org/wiki/Transformation_matrix
arc() -- The sentence "Arcs are always drawn clockwise from start to stop." is repeated; the second copy should be deleted.

I think you have added example for background which uses 4 parameters which is correct, but it needs to also have an explanation for that in the docs with a paragraph.

[perminder-17]

I see, you also haven't addressed the fix for fill() and stroke() as mentioned in the issue, can you please address it.

Really thanks for your time working on this. Also, are you interested in working this on dev-2.0 branch as well, I think the same fix are required in that branch also.

[perminder-17]

Hi @Nitin2332 , thanks for your work on this. I'm going to merge this, but the issue still doesn't closes since we want these changes in dev-2.0 branch as well. Are you interested in working on dev-2.0 branch as well. If not, I can open up a PR targeting dev-2.0 branch.

[Nitin2332]

Hi @perminder-17 , thanks for merging this!
Yes, I’m interested in making the same changes in the dev-2.0 branch as well. I’ll create a new PR targeting dev-2.0.