Skip to content

textWidth ignores leading and trailing spaces #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 437 commits into from
Closed

textWidth ignores leading and trailing spaces #8065

wants to merge 437 commits into from

Conversation

Nitin2332
Copy link
Contributor

@Nitin2332 Nitin2332 commented Sep 3, 2025 •
edited
Loading

Resolves #8052

PR Checklist

ksen0 and others added 30 commits April 17, 2025 13:13
@ksen0
Merge pull request processing#7747 from lirenjie95/fix/workflow
69e8e8e 
reorder npm run commands to make p5.js-website update the correct ver…
@ksen0
Update README.md - 2.0 Info
d377bb5
@ksen0
Merge pull request processing#7751 from processing/ksen0-patch-1
722e16a 
Update README.md - 2.0 Info
@ksen0
1.11.5
31aebe1
@ksen0
Update 1-p5.js-2.0-bug-report.yml
db82bc0
@allcontributors
docs: update README.md [skip ci]
f06e232
@allcontributors
docs: update .all-contributorsrc [skip ci]
22346d5
@davepagurek
Merge pull request processing#7766 from processing/all-contributors/a…
51a7e63 
…dd-HughJacks

docs: add HughJacks as a contributor for code
@allcontributors
docs: update README.md [skip ci]
e0fb0d4
@allcontributors
docs: update .all-contributorsrc [skip ci]
bb0128c
@raclim
Merge pull request processing#7771 from processing/all-contributors/a…
57fbaae 
…dd-jackeddielove

docs: add jackeddielove as a contributor for bug, and doc
@LalitNarayanYadav
"Fix typo in directionalLight reference (main branch)" - processing#7743
7288232
@limzykenneth
Merge pull request processing#7777 from LalitNarayanYadav/main
57638a0 
"Fix typo in directionalLight reference (main branch)" - processing#7743
@IIITM-Jay
Consistent movedX and movedY behaviour across zoom levels
fbffbc1
@VANSH3104
Fix _isglobal flag in init method and correct comments in main.js
173e095
@ksen0
Merge pull request processing#7785 from VANSH3104/global
a990d4f 
Fix  _isGlobal flag in ini method
@AhmedMagedC
Fix: keyTyped() can now accept the same char consecutively
f7233a4
@IIITM-Jay
removed redundant calling of updateMouseCoords()
197f3ee
@perminder-17
Merge pull request processing#7808 from AhmedMagedC/bug-fix-keyTyped
345f1aa 
Fix: keyTyped() can now accept the same char consecutively
@ksen0
1.11.6
f86a20e
@limzykenneth
Merge pull request processing#7795 from IIITM-Jay/mouseMovement_bugFix
7bc45ee 
Consistent `movedX` and `movedY` behaviour across zoom levels
@ksen0
Publish 1.x under r1 tag
dee8f69
@ksen0
Merge pull request processing#7810 from processing/ksen0-patch-1
64016d1 
Publish 1.x under r1 tag
@ksen0
1.11.7
5f0fcfa
@LalitNarayanYadav
Regenerate README with 64px contributor avatars
f325500
@LalitNarayanYadav
Update all-contributorsrc to set avatar image size to 64px
c5ed762
@allcontributors
docs: update README.md [skip ci]
b3802c6
@allcontributors
docs: update .all-contributorsrc [skip ci]
69e96ec
@ksen0
Merge pull request processing#7815 from processing/all-contributors/a…
8d7b72e 
…dd-clairep94

docs: add clairep94 as a contributor for code, and bug
@allcontributors
docs: update README.md [skip ci]
4d47eda
ksen0 and others added 25 commits August 21, 2025 22:37
@ksen0
Update movedX/Y documentation
852162b
@ksen0
Merge pull request processing#8030 from processing/8022
374cc96 
mouse offscreen behaviors bugfix
@ksen0
1.11.10-rc.1
d8155c0
@allcontributors
docs: update README.md [skip ci]
193e1d7
@allcontributors
docs: update .all-contributorsrc [skip ci]
7049785
@perminder-17
Merge pull request processing#8045 from processing/all-contributors/a…
1bd6caf 
…dd-MissTipo

docs: add MissTipo as a contributor for blog, code, and 4 more
@ksen0
1.11.10
a82b802
@ksen0
Merge pull request processing#8016 from awood0727/loopOptimization
e689aa7 
Replaced redundant else if statement with else statement
@ksen0
Merge pull request processing#8042 from processing/dependabot/npm_and…
5212349 
…_yarn/sha.js-2.4.12

Bump sha.js from 2.4.11 to 2.4.12
@ksen0
Merge pull request processing#8043 from processing/dependabot/npm_and…
42ebcc7 
…_yarn/cipher-base-1.0.6

Bump cipher-base from 1.0.4 to 1.0.6
@allcontributors
docs: update README.md [skip ci]
145c222
@allcontributors
docs: update .all-contributorsrc [skip ci]
ce65c8e
@allcontributors
docs: update README.md [skip ci]
3a20a57
@allcontributors
docs: update .all-contributorsrc [skip ci]
e9c9c11
@ksen0
Merge pull request processing#8053 from processing/all-contributors/a…
e4dbe6e 
…dd-kangjung

docs: add kangjung as a contributor for translation
@ksen0
Merge branch 'main' into all-contributors/add-hana-cho
7a52a5b
@AlzaAlzaki76
Fix misspellings in comment
e102815
@perminder-17
Merge pull request processing#8057 from AlzaAlzaki76/typos
e3ec433 
Fix misspellings in comment
@allcontributors
docs: update README.md [skip ci]
a8be432
@allcontributors
docs: update .all-contributorsrc [skip ci]
8f031ca
@perminder-17
Merge pull request processing#8059 from processing/all-contributors/a…
2edb445 
…dd-AlzaAlzaki76

docs: add AlzaAlzaki76 as a contributor for doc
@ksen0
Merge pull request processing#8054 from processing/all-contributors/a…
2f3ca7d 
…dd-hana-cho

docs: add hana-cho as a contributor for translation
@ksen0
Update contributor_guidelines.md
58c7068
@ksen0
Merge pull request processing#8044 from processing/ksen0-patch-2
4287c1c 
Update contributor_guidelines.md
changes
f1a6c72
@welcome Welcome
Copy link

welcome bot commented Sep 3, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

perminder-17
perminder-17 requested changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nitin2332 thanks so much for your work on this. Your work seems awesome, but the only problem here is that the changes which you have done does not point to 2.0 version of p5.js

For that, you just need to re-target your PR in dev-2.0 branch of p5.js.

Simply you can just close this PR and open a new one in dev-2.0 branch with the same changes. That should work and make your tests pass as well. Thanks.

@Nitin2332 Nitin2332 changed the base branch from main to dev-2.0 September 4, 2025 02:10
@Nitin2332 Nitin2332 closed this Sep 4, 2025
@Nitin2332 Nitin2332 deleted the fix/textwidth-spaces branch September 4, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perminder-17 perminder-17 perminder-17 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 Bug Report]: textWidth ignores leading and trailing spaces