Skip to content

pr05 Typescript Migration #12: Migrate server/mail system #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

pr05 Typescript Migration #12: Migrate server/mail system #3648

wants to merge 28 commits into from

Conversation

clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Sep 15, 2025 •
edited
Loading

pr05 Typescript Migration 12: Migrate server files related to emailing/nodemailer

Should be reviewed after #3636

Changes:

  • Migrate /server/views files related to emailing
  • Migrate /server/utils/mail
  • Extract types to /server/types/email.ts from existing logic & nodemailer types

Other:

  • Took a look at /migrations/emailConsolidation, but this requires the User and Project models to be migrated first, which I'll do next

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@clairep94
tsconfig: add tsconfig for server
1b03597
@clairep94
add typecheck:server command and add server-check to main typecheck
97c4487
@clairep94
server/utils/generateFileSystemSafeName.js: migrate to ts, no-verify
359c58c
@clairep94
server/utils/generateFileSystemSafeName: add types to params
85b9472
@clairep94
index.js: update babel/register to resolve both js and ts files
4a98bbb
@clairep94
nodemon.json: update to hot-reload on ts file changes
cf33500
@clairep94
utils/generateFileSystemSafeName: update to named export
e12ad57
@clairep94
webpack: update examples and server config files to auto-resolve ts e…
5210f5c 
…xtensions
@clairep94
webpack: update client-dev and client-prod config to auto-resolve ser…
6b5ab98 
…ver folder ts extensions after client folder
@clairep94
server/views/previewIndex: update to ts
9fb10e5
@clairep94
server/views/previewIndex: update to named export
1757455
@clairep94
server/views/index: update to ts, no-verify
0663d24
@clairep94
views/index: update to named export and add types
38409a6
@clairep94
update jest config to resolve ts files in server with babel
c69579d
@clairep94
generateFileSystemSafeName: update variable name for string
914963a
@clairep94
tsconfig: address comma dangle
a6adfec
@clairep94
views/mail: update to ts, no-verify
da7834d
@clairep94
add server/types/email and add types to views/mail
4100e11
@clairep94
views/mailLayout: migrate to ts, no-verify
483a0a5
@clairep94
views/mailLayout: update with types and update to named export
9149cbb
@clairep94
views/consolidationMailLayout: migrate to ts, no-verify
f627c85
@clairep94
views/consolidationMailLayout: add jsdocs, types and update to named …
c9c2eee 
…export
@clairep94
utils/renderMjml: update to ts, no-verify
6a23f14
@clairep94
add mjml types package, update renderMjml with types and named export…
a89dc75 
… and jsdoc
@clairep94
utils/mail: migrate to ts, no-verify
7227c44
@clairep94
add nodemailer-mailgun-transport types
ab5fa1e
@clairep94
update type definitions for mailer wrapper
836241e
@clairep94
utils/mail: update to named export
a1f4cc5
@clairep94 clairep94 changed the title Pr05/migrate mail system Pr05/migrate server/mail system Sep 15, 2025
@clairep94 clairep94 added the pr05 Grant Projects pr05 Grant Projects label Sep 15, 2025
@clairep94 clairep94 marked this pull request as ready for review September 15, 2025 22:26
@clairep94 clairep94 changed the title Pr05/migrate server/mail system pr05 Typescript Migration #13: Migrate server/mail system Sep 15, 2025
@clairep94 clairep94 changed the title pr05 Typescript Migration #13: Migrate server/mail system pr05 Typescript Migration #12: Migrate server/mail system Sep 15, 2025
@clairep94
Copy link
Collaborator Author

@raclim @khanniie Ready for review after the TS dependencies PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr05 Grant Projects pr05 Grant Projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clairep94