Skip to content

[types] permit undefined createContext initial value #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[types] permit undefined createContext initial value #3407

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6584828
[types] permit undefined createContext initial value
developit Jan 11, 2022
b6053a1
Merge branch 'master' into types-createcontext-default-value
developit Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,4 +307,4 @@ export interface Context<T> {
}
export interface PreactContext<T> extends Context<T> {}

export function createContext<T>(defaultValue: T): Context<T>;
export function createContext<T = undefined>(defaultValue: T): Context<T>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this?

Suggested change
export function createContext<T = undefined>(defaultValue: T): Context<T>;
export function createContext<T>(defaultValue: T): Context<T>;
export function createContext<T extends undefined>(defaultValue?: T): Context<T>;