Skip to content

Fix responsive dcc.Graph infinite scaling #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix responsive dcc.Graph infinite scaling #3418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions components/dash-core-components/src/fragments/Graph.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,27 +457,6 @@ class PlotlyGraph extends Component {
});
}

getStyle() {
const {responsive} = this.props;
let {style} = this.props;

// When there is no forced responsive style, return the original style property
if (!responsive) {
return style;
}

// Otherwise, if the height is not set, we make the graph size equal to the parent one
if (!style) {
style = {};
}

if (!style.height) {
return Object.assign({height: '100%'}, style);
}

return style;
}

componentDidMount() {
const p = this.plot(this.props);
this._queue = this.amendTraces(p, {}, this.props);
Expand Down Expand Up @@ -536,8 +515,7 @@ class PlotlyGraph extends Component {
}

render() {
const {className, id, loading_state} = this.props;
const style = this.getStyle();
const {className, id, loading_state, style} = this.props;

if (window.dash_component_api) {
return (
Expand Down