fix missing optional chaining on root object in nullish coalescing expression #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ucture from complex nullish coalescing patterns
0xdevalias
force-pushed
the
0xdevalias/poc-fix-complex-un-optional-chaining-bug
branch
from
5b89734 to
4a7438a
Compare
|
Wow. It adds a lot of logic. 😂 |
@pionxzh I think it may not have had the existing utils in context when it was first trying to solve it; and this way like the only version I ended up with that fully worked still; so figured I'd share it. There was a version that did better at making updates to the existing utils when I explicitly put them in scope; but then it never fully figured it out without breaking stuff. And then I gave up :p |
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky GitHub Copilot Agent based Proof-of-Concept that:
It's currently overly verbose and re-implements a lot of logic that I don't think it needs to.. but it does make the test case pass, so wanted to push this for now, and then see if we can narrow down the minimal fix from there.