Skip to content

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Sep 5, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

See also: https://github.com/pingcap/tidb/blob/master/docs/design/2021-09-29-secure-bootstrap.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested a review from qiancai September 5, 2025 14:08
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity of the documentation by providing more comprehensive details for the --initialize-secure command-line flag. The update aims to give users a better understanding of how this option configures secure bootstrapping, including the authentication method used and initial access requirements.

Highlights

  • Documentation Enhancement: The description for the --initialize-secure command-line option has been expanded to clarify its behavior, specifically mentioning the setup of a root account with auth_socket authentication and the requirement for initial socket access.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the documentation for the --initialize-secure command-line flag by providing more specific details about its function. The change is a good improvement for clarity. I've suggested a minor rephrasing to further improve readability and align more closely with the documentation style guide.

dveeden and others added 3 commits September 5, 2025 16:10
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dveeden dveeden requested review from mjonss and Oreoxmt September 5, 2025 14:16
@dveeden
Copy link
Contributor Author

dveeden commented Sep 5, 2025

Note that "Bootstraps tidb-server in secure mode" is also confusing as people might expect this to be Security Enhanced Mode (SEM) (see also https://docs.pingcap.com/tidb/stable/system-variables/#tidb_enable_enhanced_security ).

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Sep 10, 2025
@qiancai qiancai self-assigned this Sep 10, 2025
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2025
Copy link

ti-chi-bot bot commented Sep 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-10 09:00:18.910434456 +0000 UTC m=+438285.470315963: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link

ti-chi-bot bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai
Copy link
Collaborator

qiancai commented Sep 12, 2025

Note that "Bootstraps tidb-server in secure mode" is also confusing as people might expect this to be Security Enhanced Mode (SEM) (see also docs.pingcap.com/tidb/stable/system-variables#tidb_enable_enhanced_security ).

For the confusing "Bootstraps tidb-server in secure mode", I've added a suggestion #21738 (comment) here. PTAL.

Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 12, 2025
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 16, 2025

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants