Mark Memcached:: methods as impure. #4344
Open
+671
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biozshock
force-pushed
the
fix-13444
branch
from
023fb7b to
b7370a0
Compare
Comment on lines
+188
to
+194
| 'Memcached::get' => ['hasSideEffects' => true], | ||
| 'Memcached::getByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getDelayed' => ['hasSideEffects' => true], | ||
| 'Memcached::getDelayedByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getMulti' => ['hasSideEffects' => true], | ||
| 'Memcached::getMultiByKey' => ['hasSideEffects' => true], | ||
| 'Memcached::getServerByKey' => ['hasSideEffects' => true], |
There was a problem hiding this comment.
Does get method has side effects too ?
There was a problem hiding this comment.
@VincentLanglet I'm sorry, which "get" method?
The getServerByKey, where your comment is located has the side effect: https://www.php.net/manual/en/memcached.getserverbykey.php#refsect1-memcached.getserverbykey-returnvalues
There was a problem hiding this comment.
I meant all the getFoo method sonce they arr just getter
But if I understand correctly they all have side effect because they have impact on the getResultCode
There was a problem hiding this comment.
@VincentLanglet exactly. I think that i've marked all methods that change getResultCode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13444