Cleanup Cargo.tomls and licenses (dev branch) #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes it so that the MPl-2.0 license is bundled with each crate (as is best practice for license files). However, cargo does NOT currently have a better solution than copying the license to each crate's folder (see discussion here: rust-lang/cargo#13328), so this patch copies the LICENSE file to each crate's folder. This patch also consolidates a lot of the package metadata into the root Cargo.toml.
baylesj
changed the title
pdeljanov
requested changes
Aug 19, 2025
There was a problem hiding this comment.
I like the change moving the common Cargo.toml metadata to the workspace. Thanks for that. Having a license per-crate also doesn't seem like a major concern to me.
However, this PR must've been cherry-picked from master since there are a lot of changes to the dependencies that would break the build and just don't make sense. Please remove all changes to the dependencies.
| default-features = false | ||
| features = ["flac"] | ||
| symphonia-metadata = { version = "0.5.4", path = "../symphonia-metadata" } | ||
| symphonia-utils-xiph = { version = "0.5.4", path = "../symphonia-utils-xiph" } |
There was a problem hiding this comment.
Switching from symphonia-common to symphonia-utils-xiph with no code changes.
| path = "../symphonia-metadata" | ||
| default-features = false | ||
| features = ["flac"] | ||
| symphonia-metadata = { version = "0.5.4", path = "../symphonia-metadata" } |
There was a problem hiding this comment.
We only want to select the required features from the metadata crate.
Comment on lines
+33
to
+34
| arrayvec = "0.7.1" | ||
| bitflags = "1.2.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.