-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Parallel include (missing test and double check approach) #9861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
feat: Parallel include (missing test and double check approach) #9861
Conversation
…moumouls/concurrent-include # Conflicts: # package.json
I will reformat the title to use the proper commit message syntax. |
🚀 Thanks for opening this pull request! |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #9861 +/- ##
==========================================
+ Coverage 92.99% 93.00% +0.01%
==========================================
Files 187 187
Lines 15096 15106 +10
Branches 174 174
==========================================
+ Hits 14039 14050 +11
+ Misses 1045 1044 -1
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request
Issue
Related to : #6501
Closes: #7981
Approach
I try to avoid tricks and weird pattern as much as possible.
The approach is "Plan and execute", so we build a tree, and then we execute using parallel promises, and we hydrate the tree using some references
Tasks