Fix YAML parser to not treat document markers as special inside quoted strings #22397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d strings Per Dylan's guidance on issue #22392, removed the document marker checks (--- and ...) from scanSingleQuotedScalar and scanDoubleQuotedScalar. Document markers should only be recognized at the start of a line in the main document flow, not within quoted strings where they should be treated as literal text. Also removed the now-unused UnexpectedDocumentStart and UnexpectedDocumentEnd error types from both scanner functions. Note: There's a separate pre-existing issue where multiline quoted strings don't parse correctly in Bun's YAML implementation, but that's beyond the scope of this fix. Fixes #22392
|
Updated 12:56 AM PT - Sep 4th, 2025
❌ Your commit
🧪 To try this PR locally: bunx bun-pr 22397That installs a local version of the PR into your bun-22397 --bun |
WalkthroughThe YAML parser’s quoted scalar scanning logic in src/interchange/yaml.zig was updated to remove document-boundary checks for '---' and '...'. Error variants and nl state handling related to detecting document start/end inside single- and double-quoted scalars were deleted. Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22392
Summary
Per @dylan-conway's guidance on issue #22392, this PR removes the document marker checks ( and ) from and in .
The Fix
Document markers should only be recognized at the start of a line in the main document flow, not within quoted strings where they should be treated as literal text. This PR:
Testing
The fix ensures that strings like and are parsed as literal text rather than triggering document marker errors.
Note
There's a separate pre-existing issue where multiline quoted strings don't parse correctly in Bun's YAML implementation (they fail with "Expected character"), but that's beyond the scope of this fix and would require additional work on the YAML parser.