Windows codesigning for Bun's executable #20120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Jarred-Sumner wants to merge 1 commit into main from codex/add-windows-codesigning-to-github-action

Collaborator

Jarred-Sumner commented Jun 1, 2025

Summary

codesign Windows builds in GitHub Actions

Testing

pre-commit (fails: no command)

https://chatgpt.com/codex/tasks/task_e_683bcee9d0548328ac46a353f2282ad2


          chore(ci): add Windows codesigning

a6c22ad

Jarred-Sumner added the codex label

— with

ChatGPT Codex Connector

Collaborator

robobun commented Jun 1, 2025 •

edited

Loading

^{Updated 9:45 PM PT - May 31st, 2025}

❌ @Jarred-Sumner, your commit a6c22ad has 5 failures in Build #17892:

test/js/bun/net/tcp.test.ts - 1 failing on 🐧 12 x64-asan
test/js/bun/util/inspect-error-leak.test.js - 1 failing on 🐧 12 x64-asan
test/js/node/test/parallel/test-performance-measure.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-pipeline-requests-connection-leak.js - timeout on 🍎 14 aarch64
test/js/node/test/parallel/test-http-pipeline-requests-connection-leak.js - timeout on 🍎 13 aarch64
test/js/bun/spawn/spawn.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/bun/spawn/spawn.test.ts - 1 failing on 🪟 2019 x64

🧪 To try this PR locally:

bunx bun-pr 20120

That installs a local version of the PR into your bun-20120 executable, so you can run:

bun-20120 --bun

Jarred-Sumner changed the title ~~Add Windows codesigning~~ Windows codesigning for Bun's executable

Jarred-Sumner closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels