Skip to content

Conversation

antonydellavecchia
Copy link
Collaborator

@antonydellavecchia antonydellavecchia commented Aug 22, 2025

Creating a phylogenetic tree from a directed graph.

Keeps track of the permutation of the vertex ordering so that user can work with the same vertices without iknowing about the underlying polymake vertex ordering.

Labelings work as expected by using the label :leaves for the leaf nodes and :distance for the edges

@antonydellavecchia antonydellavecchia added topic: combinatorics release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Aug 22, 2025
@fingolfin
Copy link
Member

Tests fail:

      From worker 2:	Phylogenetic Trees: Error During Test at /Users/oscarci-tester/oscar-runners/oscar-runner-03/_work/Oscar.jl/Oscar.jl/test/Combinatorics/PhylogeneticTrees.jl:1
      From worker 2:	  Got exception outside of a @test
      From worker 2:	  MethodError: no method matching Oscar.PhylogeneticTree{Float64}(::Polymake.LibPolymake.BigObjectAllocated)
      From worker 2:	  
      From worker 2:	  Closest candidates are:
      From worker 2:	    (::Type{Oscar.PhylogeneticTree{T}} where T<:Union{Float64, QQFieldElem})(::Any, ::Any)
      From worker 2:	     @ Oscar ~/oscar-runners/oscar-runner-03/_work/Oscar.jl/Oscar.jl/src/Combinatorics/PhylogeneticTrees.jl:2
      From worker 2:	  
      From worker 2:	  Stacktrace:
      From worker 2:	    [1] tropical_median_consensus(arr::Vector{Oscar.PhylogeneticTree{Float64}})
      From worker 2:	      @ Oscar ~/oscar-runners/oscar-runner-03/_work/Oscar.jl/Oscar.jl/src/Combinatorics/PhylogeneticTrees.jl:286
      From worker 2:	    [2] tropical_median_consensus(::Oscar.PhylogeneticTree{Float64}, ::Oscar.PhylogeneticTree{Float64})
      From worker 2:	      @ Oscar ~/oscar-runners/oscar-runner-03/_work/Oscar.jl/Oscar.jl/src/Combinatorics/PhylogeneticTrees.jl:314
      From worker 2:	    [3] macro expansion
      From worker 2:	      @ ~/oscar-runners/oscar-runner-03/_work/Oscar.jl/Oscar.jl/test/Combinatorics/PhylogeneticTrees.jl:8 [inlined]

@benlorenz benlorenz marked this pull request as draft August 22, 2025 13:08
@benlorenz
Copy link
Member

This needs some further discussion as the current design could contradict what polymake expects for the PhylogeneticTree object.

@antonydellavecchia antonydellavecchia changed the title update PhylogeneticTree struct to contain root construct PhylogeneticTree from graph Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants