Add spacing before composer footer hints #3469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
requested review from
nornagon-openai and
edward-bayes
and removed request for
nornagon-openai
|
looks good! |
| @@ -3,4 +3,4 @@ source: tui/src/chatwidget/tests.rs | |||
| expression: terminal.backend() | |||
| --- | |||
| "▌ Ask Codex to do anything " | |||
| " ⏎ send ⌃J newline ⌃T transcript ⌃" | |||
| " " | |||
There was a problem hiding this comment.
looks like we lost the hints here? i feel this is a bit worse for very short terminals, though it's a bit of an edge case.
There was a problem hiding this comment.
I think we should optimize for the size we recommend. @edward-bayes thinks it's a better UI like that.
| let popup_constraint = match &self.active_popup { | ||
| ActivePopup::Command(popup) => Constraint::Max(popup.calculate_required_height()), | ||
| ActivePopup::File(popup) => Constraint::Max(popup.calculate_required_height()), | ||
| ActivePopup::None => Constraint::Length(FOOTER_HEIGHT_WITH_HINT), |
There was a problem hiding this comment.
i feel like this should still be Constraint::Max?
nornagon-openai
approved these changes
Sep 12, 2025
aibrahim-oai
deleted the
codex/add-space-between-composer-and-hint-text
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.