Skip to content

Os_db.init: no pool parameter means no pool at all #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Os_db.init: no pool parameter means no pool at all #478

wants to merge 1 commit into from

Conversation

ghuysmans
Copy link
Contributor

No description provided.

@vasilisp
Copy link
Contributor

Do you have a use-case for this? Why is no pool preferable to a sane default pool size?

@ghuysmans
Copy link
Contributor Author

I think the current use of None is misleading. We've measured that establishing a lot of connections is not a good thing to do, but the interface doesn't tell you about the arbitrary minimum pool size.

@jrochel jrochel force-pushed the master branch 2 times, most recently from 18b43bd to e093b83 Compare January 17, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghuysmans @vasilisp