Skip to content

Conversation

hotpineapple
Copy link
Contributor

@hotpineapple hotpineapple commented Sep 6, 2025

implement argv config for sea including snapshot

this resolves todo message:

// TODO(joyeecheung): make the arguments configurable through the JSON
// config or a programmatic API.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Sep 6, 2025
@hotpineapple hotpineapple force-pushed the feature/add-option-to-sea branch 6 times, most recently from 5fdc5d6 to 605d991 Compare September 6, 2025 16:53
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (b9fa656) to head (99ec9a4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea.cc 83.58% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59786   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         667      667           
  Lines      197207   197270   +63     
  Branches    38523    38542   +19     
=======================================
+ Hits       177407   177464   +57     
+ Misses      12242    12207   -35     
- Partials     7558     7599   +41     
Files with missing lines Coverage Δ
src/node_sea.cc 85.66% <83.58%> (-0.54%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hotpineapple hotpineapple force-pushed the feature/add-option-to-sea branch 2 times, most recently from dad1c1d to 99ec9a4 Compare September 6, 2025 17:56
implement argv config for sea including snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants