-
-
Notifications
You must be signed in to change notification settings - Fork 33k
fs: fix wrong order of file names in cpSync error message #59775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
npaun:npaun/fs-cpsync-error-wrong-order
Sep 7, 2025
Merged
fs: fix wrong order of file names in cpSync error message #59775
nodejs-github-bot
merged 1 commit into
nodejs:main
from
npaun:npaun/fs-cpsync-error-wrong-order
Sep 7, 2025
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
approved these changes
Sep 5, 2025
lpinca
approved these changes
Sep 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59775 +/- ##
==========================================
+ Coverage 89.94% 90.00% +0.05%
==========================================
Files 667 667
Lines 197207 197207
Branches 38521 38528 +7
==========================================
+ Hits 177378 177495 +117
+ Misses 12253 12130 -123
- Partials 7576 7582 +6
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Sep 5, 2025
UlisesGascon
approved these changes
Sep 5, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Sep 5, 2025
jasnell
approved these changes
Sep 6, 2025
Landed in f855cda |
targos
pushed a commit
that referenced
this pull request
Sep 9, 2025
PR-URL: #59775 Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.