feat: Add support for CSS Color Module Level 4 syntax color(...) #3256
+110
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for CSS Color Module Level 4 syntax to html2canvas, specifically the
color()function and relative color syntax withrgb(from ...)andhsl(from ...).This PR fixes/implements the following bugs/features
color(srgb r g b / alpha)syntaxMotivation
CSS Color Module Level 4 introduces new color functions and relative color syntax that are increasingly being used in modern web applications. Without this support, html2canvas throws errors when encountering these color functions, preventing proper rendering of elements that use this modern CSS syntax.
The specific issue was: