variable name collision for setting logs #587
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change the permission for the uploaded public certificate to
0644
because certain applications try to read the whole/etc/ssl/certs
directory and throw warnings if some certs can't be read.Resolve template error where loop variables log were shadowing the parent log dictionary, causing "object of type 'str' has no attribute 'error'" failures. Changed loop variable names to access_item and error_item to avoid naming conflicts. Don't enforce gzip variable to be a string.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
defaults/main/*.yml
,README.md
andCHANGELOG.md
).