Skip to content

Fix select colors #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Draft

Fix select colors #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/select/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const makeCustomTheme = theme => selectTheme => {

const getOptionColor = (theme, state) => {
if (state.isDisabled) return theme.colors.placeholder
if (state.isSelected) return theme.colors.bright
if (state.isSelected) return theme.colors.selectedStrong
return theme.colors.textDescription
}

Expand Down Expand Up @@ -152,7 +152,7 @@ const makeCustomStyles = (theme, { minWidth, size, ...providedStyles } = {}) =>
color: getOptionColor(theme, state),
":hover": {
backgroundColor: theme.colors.dropdown,
color: theme.colors.bright,
color: theme.colors.selectedStrong,
},
...(size === "tiny" ? { fontSize: "12px", minHeight: 28, padding: "4px 8px" } : {}),
}),
Expand Down
1 change: 1 addition & 0 deletions src/theme/dark/colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const appColors = {
separator: rawColors.neutral.grey35,
controlFocused: rawColors.neutral.white,
selected: rawColors.neutral.grey55,
selectedStrong: rawColors.neutral.white,
highlight: rawColors.neutral.grey55,
tooltip: rawColors.neutral.outerSpace,
bright: rawColors.neutral.white,
Expand Down
1 change: 1 addition & 0 deletions src/theme/default/colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const appColors = {
separator: rawColors.neutral.grey185,
controlFocused: rawColors.neutral.limedSpruce,
selected: rawColors.neutral.grey180,
selectedStrong: rawColors.neutral.grey50,
highlight: rawColors.neutral.grey180,

tooltip: rawColors.neutral.shark,
Expand Down