feat(@nestjs/graphql): Allow InputType Deprecation (code first) #3680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As called out in these 2 previous issues below, InputType Fields currently do not pass their deprecationReason to the generated schema.
@InputTypefield can not be deprecated #2354Issue Number: N/A
What is the new behavior?
Properly passes the deprecationReason defined on any InputType Fields along to the generated schema. This was officially supported June 3, 2022 as seen with this PR - graphql/graphql-spec#805
Does this PR introduce a breaking change?
Other information
Running the test suite locally for me required a downgrade to jest 29.x dependencies from jest 30.x. Just a callout