-
Notifications
You must be signed in to change notification settings - Fork 42.3k
refactor: Add native Python runner runtime env var #19109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add native Python runner runtime env var #19109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 5 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed that this works. A curious user might toggle that on regardless of UI hiding the option, but that shouldn't really matter (even on cloud) as it simply won't work, right?
E2E Tests: n8n tests passed after 5m 31.9s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
If a self-hoster enables it without a runner, the broker will wait indefinitely for a runner to take the task. Cloud is not a concern as we control the environment. Historically undocumented env vars haven't been an issue. |
@Cadiac Once more please, I missed that e2e relies on |
Yeah, I'm mostly concerned about someone bypassing the check on the UI (pasting in a workflow with the python task runner enabled perhaps?) and executing their WF on cloud, would that break their instance? I'd hope only the WF execution would fail. But at that point that's kind of the fault of the user, maybe not so once we start making the new runner more public |
Turns out even in that case they'll hit this error and won't hang. |
https://linear.app/n8n/issue/CAT-1290