Skip to content

Conversation

ivov
Copy link
Member

@ivov ivov commented Sep 2, 2025

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Sep 2, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

Copy link

bundlemon bot commented Sep 2, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
5.73MB (+370.51KB +6.74%) -
**/*.css
195.45KB (+4.2KB +2.19%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ontend/editor-ui/src/components/ParameterInput.vue 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ivov ivov requested a review from Cadiac September 2, 2025 15:26
Cadiac
Cadiac previously approved these changes Sep 3, 2025
Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that this works. A curious user might toggle that on regardless of UI hiding the option, but that shouldn't really matter (even on cloud) as it simply won't work, right?

Copy link

currents-bot bot commented Sep 3, 2025

E2E Tests: n8n tests passed after 5m 31.9s

🟢 550 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 66027d4

  • Spec files: 112

  • Overall tests: 550

  • Duration: 5m 31.9s

  • Parallelization: 3

Groups

GroupId Results Spec Files Progress
ui 🟢 153 · 🔴 0 · ⚪️ 0 39 / 39
No name 🟢 397 · 🔴 0 · ⚪️ 0 73 / 73


This message was posted automatically by currents.dev | Integration Settings

@ivov
Copy link
Member Author

ivov commented Sep 3, 2025

Tested and confirmed that this works. A curious user might toggle that on regardless of UI hiding the option, but that shouldn't really matter (even on cloud) as it simply won't work, right?

If a self-hoster enables it without a runner, the broker will wait indefinitely for a runner to take the task. Cloud is not a concern as we control the environment. Historically undocumented env vars haven't been an issue.

@ivov
Copy link
Member Author

ivov commented Sep 3, 2025

@Cadiac Once more please, I missed that e2e relies on action

@Cadiac
Copy link
Contributor

Cadiac commented Sep 3, 2025

Tested and confirmed that this works. A curious user might toggle that on regardless of UI hiding the option, but that shouldn't really matter (even on cloud) as it simply won't work, right?

If a self-hoster enables it without a runner, the broker will wait indefinitely for a runner to take the task. Cloud is not a concern as we control the environment. Historically undocumented env vars haven't been an issue.

Yeah, I'm mostly concerned about someone bypassing the check on the UI (pasting in a workflow with the python task runner enabled perhaps?) and executing their WF on cloud, would that break their instance? I'd hope only the WF execution would fail.

But at that point that's kind of the fault of the user, maybe not so once we start making the new runner more public

@ivov
Copy link
Member Author

ivov commented Sep 3, 2025

Tested and confirmed that this works. A curious user might toggle that on regardless of UI hiding the option, but that shouldn't really matter (even on cloud) as it simply won't work, right?

If a self-hoster enables it without a runner, the broker will wait indefinitely for a runner to take the task. Cloud is not a concern as we control the environment. Historically undocumented env vars haven't been an issue.

Yeah, I'm mostly concerned about someone bypassing the check on the UI (pasting in a workflow with the python task runner enabled perhaps?) and executing their WF on cloud, would that break their instance? I'd hope only the WF execution would fail.

But at that point that's kind of the fault of the user, maybe not so once we start making the new runner more public

Turns out even in that case they'll hit this error and won't hang.

@ivov ivov merged commit 89fc91b into master Sep 3, 2025
34 checks passed
@ivov ivov deleted the cat-1290-make-n8n_native_python_runner-a-runtime-env-var branch September 3, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants