-
Notifications
You must be signed in to change notification settings - Fork 42.6k
chore: Add mockserver for e2e testing #19104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shortstacked working on bringing this back this week.
Would love your help to figure these out if you can |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
@shortstacked this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 issues found across 12 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, but looks great! Thanks for adding this.
E2E Tests: n8n tests passed after 5m 24.8s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Thanks @shortstacked I have addressed all the feedback so far. Let me know if there's anything else. |
Summary
Add mockserver for e2e testing
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)