Skip to content

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Sep 2, 2025

Summary

Add mockserver for e2e testing

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 2, 2025
@mutdmour
Copy link
Contributor Author

mutdmour commented Sep 2, 2025

@shortstacked working on bringing this back this week.
This works well when running test:standard
Still not working:

  • proxying https requests
  • test:local is not working. throws error where n8nContainer is null when defining proxyServer

Would love your help to figure these out if you can

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mutdmour mutdmour marked this pull request as ready for review September 3, 2025 12:19
@mutdmour mutdmour changed the title chore: Add mockserver for e2e testsing chore: Add mockserver for e2e testing Sep 3, 2025
@mutdmour
Copy link
Contributor Author

mutdmour commented Sep 3, 2025

@shortstacked this is now ready for review.
I have addressed the issues mentioned above. Thanks for the help there.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 issues found across 12 files

React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.

shortstacked
shortstacked previously approved these changes Sep 3, 2025
Copy link
Contributor

@shortstacked shortstacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, but looks great! Thanks for adding this.

Copy link

currents-bot bot commented Sep 3, 2025

E2E Tests: n8n tests passed after 5m 24.8s

🟢 550 · 🔴 0 · ⚪️ 2

View Run Details

Run Details

  • Project: n8n

  • Groups: 2

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 10c2784

  • Spec files: 112

  • Overall tests: 552

  • Duration: 5m 24.8s

  • Parallelization: 3

Groups

GroupId Results Spec Files Progress
ui 🟢 158 · 🔴 0 · ⚪️ 2 40 / 40
No name 🟢 392 · 🔴 0 · ⚪️ 0 72 / 72


This message was posted automatically by currents.dev | Integration Settings

@mutdmour
Copy link
Contributor Author

mutdmour commented Sep 3, 2025

Thanks @shortstacked I have addressed all the feedback so far. Let me know if there's anything else.

@mutdmour mutdmour merged commit ce820fc into master Sep 4, 2025
45 checks passed
@mutdmour mutdmour deleted the spike-mockserver-1 branch September 4, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants