Skip to content

Conversation

afitzek
Copy link
Contributor

@afitzek afitzek commented Sep 1, 2025

Summary

This fixes a caching problem in the OIDC module. The cache was not cleared when new settings were provided, also it was not checked correctly when accessing the cache if the settings changed. This also improves setting the OIDC settings, by validating the discovery endpoint and fetching the data from it.

Related Linear tickets, Github issues, and Community forum posts

closes https://linear.app/n8n/issue/PAY-3735/improve-oidc-configuration-updates

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

bundlemon bot commented Sep 1, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
5.73MB (+370.33KB +6.73%) -
**/*.css
195.45KB (+4.2KB +2.19%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kages/frontend/editor-ui/src/views/SettingsSso.vue 81.25% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 1, 2025
@afitzek afitzek requested review from cstuncsik and MarcL September 2, 2025 08:36
@afitzek afitzek marked this pull request as ready for review September 2, 2025 08:36
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@afitzek afitzek added the release/backport Changes that need to be backported to older releases. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants