Skip to content

fix(Basic LLM Chain Node): Remove fallback connection on lower versions #19053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
+6 −8
Merged

fix(Basic LLM Chain Node): Remove fallback connection on lower versions #19053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cebdd0
fix(Basic LLM Chain Node): Remove fallback connection on lower versions
schrothbn Sep 1, 2025
799c440
Fix tests
schrothbn Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@n8n/nodes-langchain/nodes/chains/ChainLLM/methods/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function getInputs(parameters: IDataObject) {

const needsFallback = parameters?.needsFallback;

if (needsFallback === undefined || needsFallback === true) {
if (needsFallback === true) {
inputs.push({
displayName: 'Fallback Model',
maxConnections: 1,
Expand Down
12 changes: 5 additions & 7 deletions packages/@n8n/nodes-langchain/nodes/chains/ChainLLM/test/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,25 @@ describe('config', () => {
it('should return basic inputs for all parameters', () => {
const inputs = getInputs({});

expect(inputs).toHaveLength(4);
expect(inputs).toHaveLength(3);
expect(inputs[0].type).toBe(NodeConnectionTypes.Main);
expect(inputs[1].type).toBe(NodeConnectionTypes.AiLanguageModel);
expect(inputs[2].type).toBe(NodeConnectionTypes.AiLanguageModel);
expect(inputs[3].type).toBe(NodeConnectionTypes.AiOutputParser);
expect(inputs[2].type).toBe(NodeConnectionTypes.AiOutputParser);
});

it('should exclude the OutputParser when hasOutputParser is false', () => {
const inputs = getInputs({ hasOutputParser: false });

expect(inputs).toHaveLength(3);
expect(inputs).toHaveLength(2);
expect(inputs[0].type).toBe(NodeConnectionTypes.Main);
expect(inputs[1].type).toBe(NodeConnectionTypes.AiLanguageModel);
expect(inputs[2].type).toBe(NodeConnectionTypes.AiLanguageModel);
});

it('should include the OutputParser when hasOutputParser is true', () => {
const inputs = getInputs({ hasOutputParser: true });

expect(inputs).toHaveLength(4);
expect(inputs[3].type).toBe(NodeConnectionTypes.AiOutputParser);
expect(inputs).toHaveLength(3);
expect(inputs[2].type).toBe(NodeConnectionTypes.AiOutputParser);
});

it('should exclude the FallbackInput when needsFallback is false', () => {
Expand Down
Loading