Skip to content

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Sep 1, 2025

Summary

Truncate variable values to stop the action column from going off screen

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 1, 2025
Copy link

bundlemon bot commented Sep 1, 2025

BundleMon

Unchanged files (2)
Status Path Size Limits
WASM Dependencies
tree-sitter-bash.wasm
181.26KB -
WASM Dependencies
tree-sitter.wasm
74.47KB -

No change in files bundle size

Groups updated (2)
Status Path Size Limits
**/*.js
5.72MB (+361.11KB +6.57%) -
**/*.css
195.09KB (+3.84KB +2.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@r00gm r00gm marked this pull request as ready for review September 1, 2025 08:36
@r00gm r00gm requested review from Copilot and cstuncsik September 1, 2025 08:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prevents variable value overflow in the Variables View by truncating long values that would cause the action column to go off screen.

  • Replaces direct value display with a truncated span element using the v-n8n-truncate directive
  • Adds test coverage to verify that long variable values are properly truncated at 20 characters

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/frontend/editor-ui/src/views/VariablesView.vue Implements value truncation using v-n8n-truncate directive with 20 character limit
packages/frontend/editor-ui/src/views/VariablesView.test.ts Adds test case to verify truncation behavior for long variable values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant