chore: NODE-3557 - Generate Schema Files (no-changelog) #19018
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| @@ -33,6 +33,22 @@ | |||
| "kind": { | |||
| "type": "string" | |||
| }, | |||
| "localizations": { | |||
There was a problem hiding this comment.
localizations defines only the 'en' key, leaving other locale keys unconstrained; model all locales with patternProperties or additionalProperties so each locale maps to { title, description }.
(Based on your team's feedback about keeping review comments concise, this focuses on the specific schema shape change.)
Prompt for AI agents
Address the following comment on packages/nodes-base/nodes/Google/YouTube/__schema__/v1.0.0/video/get.json at line 36:
<comment>localizations defines only the 'en' key, leaving other locale keys unconstrained; model all locales with patternProperties or additionalProperties so each locale maps to { title, description }.
(Based on your team's feedback about keeping review comments concise, this focuses on the specific schema shape change.)</comment>
<file context>
@@ -33,6 +33,22 @@
"kind": {
"type": "string"
},
+ "localizations": {
+ "type": "object",
+ "properties": {
</file context>
| "type": "null" | ||
| }, | ||
| "SystemModstamp": { | ||
| "error": { |
There was a problem hiding this comment.
Replacing the account GET schema with an error string field is inconsistent with other GET schemas and likely incorrect; GET schemas enumerate object fields, not an error-only shape.
(Based on your team's feedback about not assuming prior response shape, I verified by comparing other Salesforce get.json schemas and searching the repo for error fields in get.json.)
Prompt for AI agents
Address the following comment on packages/nodes-base/nodes/Salesforce/__schema__/v1.0.0/account/get.json at line 4:
<comment>Replacing the account GET schema with an error string field is inconsistent with other GET schemas and likely incorrect; GET schemas enumerate object fields, not an error-only shape.
(Based on your team's feedback about not assuming prior response shape, I verified by comparing other Salesforce get.json schemas and searching the repo for error fields in get.json.)</comment>
<file context>
@@ -1,56 +1,9 @@
- "type": "null"
- },
- "SystemModstamp": {
+ "error": {
"type": "string"
}
</file context>
| "id": { | ||
| "type": "string" | ||
| }, | ||
| "preferredLanguage": { | ||
| "type": "null" |
There was a problem hiding this comment.
preferredLanguage is constrained to null-only; it should allow string (and optionally null) to match the expected user resource contract and avoid rejecting valid values.
Prompt for AI agents
Address the following comment on packages/nodes-base/nodes/Microsoft/Entra/__schema__/v1.0.0/user/create.json at line 23:
<comment>preferredLanguage is constrained to null-only; it should allow string (and optionally null) to match the expected user resource contract and avoid rejecting valid values.</comment>
<file context>
@@ -16,15 +16,15 @@
"type": "string"
},
+ "preferredLanguage": {
+ "type": "null"
+ },
"userPrincipalName": {
</file context>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
No description provided.