feat(Mindee Node): Update Mindee node to support Mindee V2 API #18986
Conversation
|
|
n8n-assistant
bot
added
community
|
Hey @sebastianMindee, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
| @@ -5,10 +5,10 @@ import type { | |||
| INodeProperties, | |||
| } from 'n8n-workflow'; | |||
|
|
|||
| export class MindeeInvoiceApi implements ICredentialType { | |||
There was a problem hiding this comment.
This is a breaking change and should be avoided, I would keep the name the same. It also looks like w ealready support the Authorization header so likely won't need to change this at all.
|
|
||
| const version = this.getNodeParameter('apiVersion', 0) as number; | ||
| // V1 of mindee is deprecated, we are keeping it for now but now V3 is active | ||
| const url = |
| @@ -1,22 +1,24 @@ | |||
| // eslint-disable-next-line import-x/no-extraneous-dependencies | |||
There was a problem hiding this comment.
This shouldn't be needed, Avoid disabling eslint rules where possible
|
|
||
| export class Mindee implements INodeType { | ||
| description: INodeTypeDescription = { | ||
| displayName: 'Mindee', | ||
| name: 'mindee', | ||
| icon: 'file:mindee.svg', | ||
| group: ['input'], | ||
| version: [1, 2, 3], | ||
| subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', | ||
| version: [1, 2, 3, 4], |
There was a problem hiding this comment.
This change should really be a full version, Create a v2 folder and avoid changing any of the code here.
Summary
Context: Mindee will EOL the support for its old syntax in favor of the V2 before the end of 2025.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)