-
Notifications
You must be signed in to change notification settings - Fork 79
WIP - chore(deps): add test for $lookup with field level encryption COMPASS-8816 #2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
623b4fa
to
68affa2
Compare
"optionalDependencies": { | ||
"kerberos": "2.1.0", | ||
"mongodb-client-encryption": "^6.1.1" | ||
"mongodb-client-encryption": "^6.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like mongodb-client-encryption
was previously bumped but this package was left at the old version; was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think that's just an oversight (or maybe a bad merge conflict resolve?) 👍
68affa2
to
28a4945
Compare
Just quoting myself from the ticket:
This should probably be an e2e test since we don't have the infrastructure for integration tests with the crypt_shared library in place in the shell-api package, and all similar tests are also e2e tests. And, well, we need the 8.1 crypt_shared library, and that's not released yet. |
28a4945
to
a9a00c2
Compare
a9a00c2
to
d6a3394
Compare
…pdate-mongo-crypt
It has previously been not possible to use $lookup stage of a pipeline with automatic encryption attached to it. This adds a test to verify it is possible along with another dependency bump.