refactor(test-runner-core): remove unused configFilePath
option and TestSessionGroup
type.
#2983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to fix #2982. I removed the logic that makes test file discovery relative to the specified
configFilePath
. Now the behavior is the same as when noconfigFilePath
is specified, i.e. files are found relative to the working directory. After removing that logic, I realized theconfigFilePath
option was no longer used anywhere, so I removed it completely. This is a breaking change for anyone using that option. However, given that the option doesn't really do anything, this is probably of minimal impact.While familiarizing myself with the code base, I also noticed that the
sessionGroups
variable is never used. Removing that and propagating the change through the code base ultimately led to the removal of the unusedTestSessionGroup
type and a change to theTestSessionManager
constructor signature. These are also technically breaking changes for anyone who imports@web/test-runner-core
directly.