Skip to content

Conversation

wjhsf
Copy link

@wjhsf wjhsf commented Sep 4, 2025

The primary purpose of this PR is to fix #2982. I removed the logic that makes test file discovery relative to the specified configFilePath. Now the behavior is the same as when no configFilePath is specified, i.e. files are found relative to the working directory. After removing that logic, I realized the configFilePath option was no longer used anywhere, so I removed it completely. This is a breaking change for anyone using that option. However, given that the option doesn't really do anything, this is probably of minimal impact.

While familiarizing myself with the code base, I also noticed that the sessionGroups variable is never used. Removing that and propagating the change through the code base ultimately led to the removal of the unused TestSessionGroup type and a change to the TestSessionManager constructor signature. These are also technically breaking changes for anyone who imports @web/test-runner-core directly.

Copy link

changeset-bot bot commented Sep 4, 2025

⚠️ No Changeset found

Latest commit: 75522a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-runner configFilePath option makes incorrect assumption about directory structure
1 participant