-
Notifications
You must be signed in to change notification settings - Fork 202
feat(locadex): setup i18n #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Localization Complete for Docs!Your repository has been successfully internationalized! 🎉 📋 SummaryLocadex has analyzed your repository and generated translations for your translatable content. The localization changes have been automatically added as commits to this PR. 🔗 What happened?
✅ Ready to MergeThis PR is now ready to be reviewed and merged! All localization changes have been included. Localization completed by the Locadex bot in 165 seconds. |
This is looking good. Just adding some notes: Overall, not translating acronyms makes sense and terms like CLI and API are preserved across languages. But in Chinese, this looks a bit off. Accordion titles aren't translated. I assume because they're in |
Thanks @ethanpalm -- @fernando-aviles is addressing these and will make a PR to this setup branch shortly! |
Thanks @archie-mckenzie! I noticed that code snippet titles also aren't translated, which seems like it's probably the same problem as accordion titles. Edit: I think it's actually only for |
Hey @ethanpalm we made some updates to our translation engine to handle the Accordion title translations. It also cleaned up the Chinese. Made a PR so we can add it to this branch and you can check it out: gt-retranslate In general, mixing of Latin script with other scripts will happen for many proper nouns. But we can always add project rules that will opt for approaches like transliteration in these cases. Can discuss different approaches. As for the snippet titles, these are currently being stored as codeblock metadata. We don't translate these because we might touch specific keywords (for example 'wrap' in this case). Thinking the best approach would be to build a Mintlify-specific solution so we can translate non-keyword terms. ![]() |
🌐 Locadex Setup
This PR sets up Locadex for automated internationalization in your repository. It is ready to be merged.
1ff68ec7ce53c56e1d96adffae0b7cf4e0cfb8bbfef81f0d80cd4e66b0201991