-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Add diff indicators support to chat multi-diff content part #264100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
@copilot No, the change needs to be made in src/vs/workbench/contrib/chat/browser/chatContentParts/chatMultiDiffContentPart.ts. You should optionally allow this data to be provided by the caller (along with the file name, diffs, etc...) |
@copilot No, the change needs to be made in src/vs/workbench/contrib/chat/browser/chatContentParts/chatMultiDiffContentPart.ts. You should optionally allow this data to be provided by the caller (along with the file name, diffs, etc...) |
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
You're absolutely right! I moved the change to
The caller can now optionally provide diff statistics along with file names and diff URIs, and they'll be displayed just like in the regular chat references. Commit: 23c37b4 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
اطفاء شبكة مربوطه في الراس
في الثلاثاء، ٢ سبتمبر ٢٠٢٥، ٧:١٦ م Copilot ***@***.***> كتب:
… *Copilot* left a comment (microsoft/vscode#264100)
<#264100 (comment)>
@copilot <https://gh.io/copilot-coding-agent-docs> No, the change needs
to be made in
src/vs/workbench/contrib/chat/browser/chatContentParts/chatMultiDiffContentPart.ts.
You should optionally allow this data to be provided by the caller (alon...
You're absolutely right! I moved the change to chatMultiDiffContentPart.ts
as requested. The fix now:
1. Extends IChatMultiDiffData to optionally include diffMeta with
added/removed line counts
2. Updates the ChatMultiDiffListRenderer to display "+X -Y" indicators
when diff metadata is provided
3. Properly handles cases where no diff metadata is available (hides
indicators)
The caller can now optionally provide diff statistics along with file
names and diff URIs, and they'll be displayed just like in the regular chat
references.
Commit: 23c37b4
—
Reply to this email directly, view it on GitHub
<#264100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQAQWQV4Z3HR64LWGYK5B2L3QW7HXAVCNFSM6AAAAACFFYQD52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBVHE3TMOJVGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@copilot fix the formatting issue
|
…tPart Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
The coding agent changed files list was missing the green/red diff indicators (+12 -0) that show lines added and removed, unlike regular chat which displays these indicators correctly.
Before
After
Changes Made
Extended IChatMultiDiffData Interface
Added optional
diffMeta
field to resource entries to carry diff statistics:Enhanced ChatMultiDiffListRenderer
Backward Compatibility
The changes are fully backward compatible - existing callers that don't provide diff metadata will continue to work unchanged, while new callers can optionally include diff statistics.
The fix ensures that when coding agents modify files, users see the same helpful diff indicators (+lines added, -lines removed) that appear in regular chat, providing better transparency about the scope of changes.
Recent Updates
Fixes #258613.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.