Defer checking call and new expressions with context sensitive arguments #62381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Sep 2, 2025
| @@ -190,8 +190,8 @@ test("windows-process-tree", async () => { | |||
| > : ^^^^^^^^^^^^ | |||
| >"windows-process-tree" : "windows-process-tree" | |||
| > : ^^^^^^^^^^^^^^^^^^^^^^ | |||
| >async () => { return new Promise((resolve, reject) => { getProcessTree(123, (tree) => { if (tree) { resolve(); } else { reject(new Error("windows-process-tree")); } }); });} : () => Promise<void> | |||
| > : ^^^^^^^^^^^^^^^^^^^ | |||
| >async () => { return new Promise((resolve, reject) => { getProcessTree(123, (tree) => { if (tree) { resolve(); } else { reject(new Error("windows-process-tree")); } }); });} : (this: Context) => Promise<void> | |||
There was a problem hiding this comment.
assigned this parameter in an arrow isn't anything new, it can happen with other context-sensitive arguments with this signature: TS playground
Andarist
commented
Sep 2, 2025
src/compiler/checker.ts
Outdated
Comment on lines
37060
to
37063
| if (!node.typeArguments && checkMode & CheckMode.SkipContextSensitive && isContextSensitive(node)) { | ||
| skippedGenericFunction(node, checkMode); | ||
| return resolvingSignature; | ||
| } |
There was a problem hiding this comment.
This PR is put together quickly - as an experiment. I didn't think through how those new codepaths that call skippedGenericFunction and return resolvingSignature might affect existing code.
The existing test suite doesn't immediately show this is a terrible idea though. It would be nice if an extended test suite could be ran for this experiment. cc @jakebailey
EDIT:// actually... the self-check fails here so it's probably not worth running the extended test suite at this point
There was a problem hiding this comment.
@jakebailey could you run tests here now? I kinda fully expect this PR to be garbage and break things but I'd like to get some test cases from the compiler usage in the wild that could be included in the in-repo test suite
|
self-check repro: TS playground |
|
@typescript-bot test it |
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: screeps |
|
@jakebailey Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
Repros:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #62380