NFC: Fix python literal string errors in TestRunner.py #7504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
tex3d
changed the title
llvm-beanz
approved these changes
Jul 11, 2025
bogner
approved these changes
Sep 17, 2025
Comment on lines
+441
to
+443
| re_cond_end = re.compile("%{") | ||
| re_if = re.compile("(.*?)(?:%if)") | ||
| re_nested_if = re.compile("(.*?)(?:%if|%})") |
There was a problem hiding this comment.
Should we use raw strings for all of these for consistency? I think it's more or less a best practice to always use raw strings for the input to re. functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some long-standing errors reported from lit/TestRunner.py due to a need to specify
rfor raw strings for a few regular expressions that contain invalid escape sequences otherwise.