Skip to content

Conversation

Roman-Weisman
Copy link
Contributor

Instead of selecting items one by one, this change allows multi selection by providing a range.
For example: 1-3 will select items 1, 2 and 3.

Instead of selecting items one by one, this change allows multi
selection by providing a range.
For example: 1-3 will select items 1, 2 and 3.
@Roman-Weisman
Copy link
Contributor Author

Youtube: https://youtu.be/wl_q5X6BFg4

Copy link
Owner

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I added a fixup to simplify a couple of things, could you please check the changes?

mfussenegger and others added 2 commits January 6, 2025 17:52
Code looks way better, I did edit the regex for it to accept spaces.
Valid input: 1-5.
Also valid input: 1 - 5.
Copy link
Contributor Author

@Roman-Weisman Roman-Weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, added change to the regex.

@Roman-Weisman
Copy link
Contributor Author

Youtube: https://youtu.be/u7mEnQv2zE8

@mfussenegger mfussenegger merged commit 88cee0a into mfussenegger:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants