-
-
Notifications
You must be signed in to change notification settings - Fork 8k
fix: round up label width in ER diagram for Safari #6641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix: round up label width in ER diagram for Safari #6641
Conversation
On Safari, subpixel gets rounded differently than in Chromium-based browsers, leading to issues like mermaid-js#6640 This change, rounds up the size of the labels and its containers to prevent the issue.
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6641 +/- ##
==========================================
- Coverage 3.87% 3.87% -0.01%
==========================================
Files 413 414 +1
Lines 43292 43304 +12
Branches 666 666
==========================================
Hits 1679 1679
- Misses 41613 41625 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@ashishjain0512 @shubhamparikh2704 👋 Did you get a chance to review this change? |
📑 Summary
On Safari, subpixel gets rounded differently than in Chromium-based browsers, leading to issues like #6640 This change, rounds up the size of the labels and its containers to prevent the issue.
Resolves #6640
📏 Design Decisions
This just rounds up the size of the label. As far as I can tell, everything renders correctly - however I am not sure about downstream effects of this change and a thorough review would be appreciated.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.