Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jul 14, 2025

No impact on functionality, just keeping up with the Joneses.

@Copilot Copilot AI review requested due to automatic review settings July 14, 2025 16:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes the Jackson version in gradle.properties and bumps all Jackson dependencies to 2.19.0.

  • Introduce jacksonVersion property in gradle.properties
  • Update all Gradle build files to use ${jacksonVersion} for Jackson modules
  • Bump versions in pom.xml and NOTICE.txt to 2.19.0

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test-app/build.gradle Switched jackson-databind to use ${jacksonVersion}
pom.xml Bumped jackson-core, annotations, databind, and csv to 2.19.0
ml-development-tools/build.gradle Updated jackson-module-kotlin to use ${jacksonVersion}
marklogic-client-api/build.gradle Switched jackson-databind and csv to use ${jacksonVersion}
marklogic-client-api-functionaltests/build.gradle Updated jackson-core and databind to use ${jacksonVersion}
gradle.properties Added jacksonVersion=2.19.0 property and explanatory comment
examples/build.gradle Switched jackson-databind to use ${jacksonVersion}
NOTICE.txt Updated Jackson notices for databind and csv to 2.19.0

@@ -3,6 +3,9 @@ version=7.2-SNAPSHOT
describedName=MarkLogic Java Client API
publishUrl=file:../marklogic-java/releases

# See https://github.com/FasterXML/jackson for more information the Jackson libraries.
Copy link
Preview

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Fix grammar in the comment: change 'more information the Jackson libraries' to 'more information on the Jackson libraries'.

Suggested change
# See https://github.com/FasterXML/jackson for more information the Jackson libraries.
# See https://github.com/FasterXML/jackson for more information on the Jackson libraries.

Copilot uses AI. Check for mistakes.

BillFarber
BillFarber previously approved these changes Jul 14, 2025
No impact on functionality, just keeping up with the Joneses.
@rjrudin rjrudin merged commit fa99ed4 into develop Jul 14, 2025
1 of 2 checks passed
@rjrudin rjrudin deleted the feature/22919-jackson branch July 14, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants