-
-
Notifications
You must be signed in to change notification settings - Fork 961
feat(icons): added mail-dot
icon
#3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(icons): added mail-dot
icon
#3230
Conversation
Added or changed iconsIcons as codeWorks for: const MailDotIcon = createLucideIcon('MailDot', [
["path",{"d":"M12.674 4H4a2 2 0 0 0-2 2v12a2 2 0 0 0 2 2h16a2 2 0 0 0 2-2v-4.675"}],
["path",{"d":"m2 7 9 5.701a2 2 0 0 0 2 0l1.084-.686"}],
["circle",{"cx":"19","cy":"7","r":"3"}]
]) |
Hi @elenakovelskikh, This feels like a solid use case, but adding the dot to bottom right corner would feel more consistent with the rest of our mail icon variants, I think. 🤔 ![]() |
Hi @karsa-mistmere, thanks for the input! I see the reasoning behind aligning with the position of semantic icons like the exclamation mark or search, but in this case I think the notification dot follows a different logic. It's not a part of the icon's core meaning, but rather a status indicator — similar to what we see in most UI systems today. For clarity and consistency with common UX patterns, I believe top-right is the more intuitive placement for users. I also aligned the design with existing icons in the set, like monitor-dot, ball-dot, and message-square-dot, all of which place the dot in the top-right position. |
I understand the reasoning, but I think in that case, the dot's placement should be in line with |
@karsa-mistmere, thank you for your feedback! You're right — if we compare it with the two existing icons in the set, the dot could indeed be aligned with the top edge of the base object to stay consistent. Before submitting the PR, I spent some time testing different placements. I still feel that slightly raising the dot — so it "sits" a bit outside the main shape — helps reinforce its role as a marker rather than a part of the icon itself. By letting it "stick out" a little, we enhance its visibility and clearly signal that it's a status indicator: Please let me know what you think. |
With fixed bottom right corner: |
@karsa-mistmere @jguddas Thank you! I agree with your reasoning, and I’ve updated the SVG file accordingly. |
I was just about to submit a request for this exact icon (same name and all) so it is definitely wanted 😎 |
Again, while I do understand the reasoning as to why the dot should be in the top right corner, I do not necessarily agree with it and still firmly believe that this layout is simply much more legible and overall more consistent with the existing icon set. |
3a24846
to
b553557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT Tags suggestions ✨
I've asked ChatGPT for some suggestions for tags.
"jguddas", | ||
"elenakovelskikh" | ||
], | ||
"tags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for the mail-dot
icon.
Try asking it your self if you want more suggestions. Open ChatGPT
Here are the suggestions:
"tags": [ | |
"tags": [ | |
"mail", | |
"envelope", | |
"communication", | |
"post", | |
"send", | |
"address", | |
"notification", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to add this icon, but notice this pull request. Although initially I thought bottom right to pair with the other mail items, I think this has enough reason to be top right. Especially when UX is involved.
Although all these icons are based on an envelope, I don't think many will be used with in close proximity of each other. mail and mail-dot are the most likely to be used, but I don't think theses consistency issues would be a problem in real world usage. |
You make a fair point, and I agree it shouldn't be used for highlighting the presence of notifications. |
Using no label for such an action would be bad UX and lacking in a11y anyway. |
It's the usual should we be internally consistent, or should we follow Jakobs law. We haven't written it in stone but the usual decision has been to follow Jakobs law, in this case that would mean putting the dot in the top right corner. |
What is the purpose of this pull request?
Description
Added new
mail-dot
icon.Icon use case
Used to indicate that there is a new or unread message. Commonly used in messaging systems, inboxes, or notification areas to draw attention to recent activity.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
mail
monitor-dot
bell-dot
message-square-dot
Naming
icons/[iconName].json
.Design
Before Submitting