♻️ refactor: refactor send message to speed up #9046
Draft
+771
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9046 +/- ##
==========================================
- Coverage 77.06% 76.60% -0.47%
==========================================
Files 814 816 +2
Lines 48902 49237 +335
Branches 6343 5219 -1124
==========================================
+ Hits 37688 37719 +31
- Misses 11208 11512 +304
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Reviewer's GuideThis PR refactors the chat message flow to leverage a dedicated server-side API for faster processing by routing sendMessage calls to a new server-mode pathway, updating topics and messages in bulk via new reducer actions, and providing corresponding backend router and service implementations. It also includes miscellaneous type and configuration adjustments for imports, optional parameters, and build settings. Sequence diagram for the new server-side sendMessage flowsequenceDiagram
participant User
participant Frontend
participant AiChatService (frontend)
participant LambdaClient
participant LambdaRouter (backend)
participant AiChatService (backend)
participant MessageModel
participant TopicModel
User->>Frontend: Triggers sendMessage
Frontend->>AiChatService (frontend): sendMessageInServer(params)
AiChatService (frontend)->>LambdaClient: aiChat.sendMessageInServer.mutate(params)
LambdaClient->>LambdaRouter (backend): sendMessageInServer
LambdaRouter (backend)->>AiChatService (backend): getMessagesAndTopics
AiChatService (backend)->>MessageModel: query messages
AiChatService (backend)->>TopicModel: query topics
MessageModel-->>AiChatService (backend): messages
TopicModel-->>AiChatService (backend): topics
AiChatService (backend)-->>LambdaRouter (backend): {messages, topics}
LambdaRouter (backend)-->>LambdaClient: response
LambdaClient-->>AiChatService (frontend): response
AiChatService (frontend)-->>Frontend: response
Frontend->>Frontend: internal_dispatchTopic/updateTopics
Frontend->>Frontend: internal_dispatchMessage/updateMessages
Class diagram for updated reducers with bulk update actionsclassDiagram
class topicReducer {
+updateTopics(value: ChatTopic[]): ChatTopic[]
}
class messagesReducer {
+updateMessages(value: ChatMessage[]): ChatMessage[]
}
class ChatTopicDispatch {
+AddChatTopicAction
+UpdateChatTopicAction
+DeleteChatTopicAction
+UpdateTopicsAction
}
class MessageDispatch {
+CreateMessage
+UpdateMessage
+UpdateMessages
+UpdatePluginState
+UpdateMessageExtra
+DeleteMessage
}
topicReducer --> ChatTopicDispatch
messagesReducer --> MessageDispatch
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
👍 @arvinxx Thank you for raising your pull request and contributing to our Community |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arvinxx
force-pushed
the
refactor/send-message
branch
from
8858218 to
d6ef723
Compare
|
和 https://lobe-chat-database-git-fork-sxjeru-93-lobehub-community.vercel.app/chat?topic=tpc_qGGsnIGwf6B2 对比了下还是可以明显感觉出快了 2, 3s 的 |
arvinxx
force-pushed
the
refactor/send-message
branch
from
fea6423 to
5903b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information
Summary by Sourcery
Offload AI chat messaging to the server via new TRPC endpoints and client service, integrate a V2 chat action in the store, and improve performance with batched state updates
New Features:
Enhancements:
Build:
Chores: