[TOSA] Update TOSA's rounding mode, nan propagation and resize mode to enums #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o enums Context: TOSA's rounding mode, nan propagation, and resize mode have been updated from string attributes to enums. This commit updates the Torch to TOSA path to align with those changes. Signed-off-by: Justin Ngo <justin.ngo@arm.com>
|
Hi @vivekkhandelwal1, next time that you bump LLVM within Torch-MLIR, you will find that there are TOSA-related breaking changes. The updates included in this PR should help you resolve those breakages. I tried to bump the LLVM version in Torch-MLIR myself, but there were some other non-TOSA related issues that I didn't have the bandwidths to look into, so I only worked on a fix the TOSA ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: TOSA's rounding mode, nan propagation, and resize mode have been updated from string attributes to enums.
This commit updates the Torch to TOSA path to align with those changes.