Allow in-memory IOStreams to be of length 0 #13840
Open
+2
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the arbitrary and unnecessarily restrictive limitation of in-memory IOStream instances being disallowed from having a length of 0. This is particularly problematic for the cases of creating a stream from a zero-length string & of creating an in-memory cache of an empty file. I looked at the internals and the implementation already prevents any access to the memory pointer if the length is zero, and even the pointer math being performed on the internal cursors work out to a correct result when the memory pointer is NULL. I even built and tested my own SDL3.dll with this change and everything worked fine.
In particular, the checks at the top of SDL_IOFromMem and SDL_IOFromConstMem have been changed to only emit an error in the case of the length being >0 and also the memory pointer being NULL, otherwise allowing the stream to be created as normal.