Skip to content

Conversation

herbdool
Copy link

Fixes #91

Copy link
Contributor

@RomainMILLAN RomainMILLAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see new parameters on function, mayby un update of doc is necessary ?

'jql' => $jql,
]);

$ret = $this->exec('search//approximate-count', $data, 'POST');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propal : search/approximate-count

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomainMILLAN it's got a double slash because single slash gets stripped out. I'm not sure why but decided to just work around it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library assumes that you'll add a / in the beginning of the route, you can change it to /search/approximate-count

@herbdool
Copy link
Author

herbdool commented May 7, 2025

@RomainMILLAN I could include the doc changes, if the approach in this PR is acceptable to the maintainer.

@SkaveRat
Copy link

For about a week, I'm using this PR for my project and so far it works without problems. Although I'm not doing anything super complex

@gbarbieru
Copy link

any updates on this ? i'm waiting for it to get released :D

@herbdool
Copy link
Author

herbdool commented Sep 8, 2025

There hasn't been any activity in this repo in about 5 months. For now I'm using composer and this package https://docs.cweagans.net/composer-patches/ to patch the repo when building.

@Ken-vdE
Copy link

Ken-vdE commented Sep 10, 2025

Well, let's wake 'em up with notifications.
HELLO, fix pls!

@toschl
Copy link

toschl commented Sep 15, 2025

For me, the old endpoint is EOL by today. Would be nice this could be released.

@you-loan
Copy link

I'm facing with the same issue. It will be great to have this fixed as soon as possible.

@reindeer77
Copy link

Same issue. Would be awesome to release this.

@churris43
Copy link

Highly appreciated if this can be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of search enpoints
10 participants