-
Notifications
You must be signed in to change notification settings - Fork 44
Issue #91: update search() to work with search/jql #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see new parameters on function, mayby un update of doc is necessary ?
'jql' => $jql, | ||
]); | ||
|
||
$ret = $this->exec('search//approximate-count', $data, 'POST'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
propal : search/approximate-count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomainMILLAN it's got a double slash because single slash gets stripped out. I'm not sure why but decided to just work around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library assumes that you'll add a /
in the beginning of the route, you can change it to /search/approximate-count
@RomainMILLAN I could include the doc changes, if the approach in this PR is acceptable to the maintainer. |
For about a week, I'm using this PR for my project and so far it works without problems. Although I'm not doing anything super complex |
any updates on this ? i'm waiting for it to get released :D |
There hasn't been any activity in this repo in about 5 months. For now I'm using composer and this package https://docs.cweagans.net/composer-patches/ to patch the repo when building. |
Well, let's wake 'em up with notifications. |
For me, the old endpoint is EOL by today. Would be nice this could be released. |
I'm facing with the same issue. It will be great to have this fixed as soon as possible. |
Same issue. Would be awesome to release this. |
Highly appreciated if this can be fixed |
Fixes #91