Skip to content

remove bare list, dict, Sequence, None, Any #25058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 5, 2025
Merged

remove bare list, dict, Sequence, None, Any #25058

merged 13 commits into from
Sep 5, 2025
+787 −817

Conversation

asukaminato0721
Copy link
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

part of #25057

Summary

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@asukaminato0721 asukaminato0721 changed the title remove bare list, dict, Sequence remove bare list, dict, Sequence, None Sep 3, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review September 3, 2025 05:30
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Sep 3, 2025
@asukaminato0721 asukaminato0721 changed the title remove bare list, dict, Sequence, None remove bare list, dict, Sequence, None, Any Sep 3, 2025
@asukaminato0721
Copy link
Contributor Author

@laipz8200

laipz8200
laipz8200 requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

110/300

laipz8200
laipz8200 requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

300/300

@asukaminato0721
Copy link
Contributor Author

error: "Literal[True]" is not iterable

@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 12:09
Copilot
Copilot AI reviewed Sep 5, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2025
@laipz8200 laipz8200 merged commit a78339a into langgenius:main Sep 5, 2025
12 checks passed
@asukaminato0721 asukaminato0721 deleted the remove-return-type branch September 6, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asukaminato0721 @laipz8200