Skip to content

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 2, 2025

No description provided.

@cbornet cbornet requested a review from eyurtsev as a code owner September 2, 2025 10:20
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 8, 2025 3:55pm

@@ -758,7 +758,7 @@ async def test_chat_tmpl_from_messages_multipart_image() -> None:

async def test_chat_tmpl_from_messages_multipart_formatting_with_path() -> None:
"""Verify that we cannot pass `path` for an image as a variable."""
in_mem = "base64mem"
in_mem_ = "base64mem"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes ambiguity with "image_url": "data:image/jpeg;base64,{in_mem}"

Copy link

codspeed-hq bot commented Sep 2, 2025

CodSpeed WallTime Performance Report

Merging #32785 will not alter performance

Comparing cbornet:ruff-core-preview-2 (b931efd) with master (f4e83e0)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Sep 2, 2025

CodSpeed Instrumentation Performance Report

Merging #32785 will not alter performance

Comparing cbornet:ruff-core-preview-2 (b931efd) with master (f4e83e0)

Summary

✅ 14 untouched benchmarks

@cbornet cbornet force-pushed the ruff-core-preview-2 branch 3 times, most recently from 96972cb to c3dae9f Compare September 2, 2025 13:47
@mdrxy mdrxy added linting Linting, formatting, or typing core Related to the package `langchain-core` labels Sep 3, 2025
@cbornet cbornet force-pushed the ruff-core-preview-2 branch 4 times, most recently from 79ed9f7 to 367ab10 Compare September 5, 2025 08:39
@cbornet cbornet force-pushed the ruff-core-preview-2 branch from 367ab10 to 0ef54ad Compare September 5, 2025 09:07
@cbornet cbornet force-pushed the ruff-core-preview-2 branch from eb8f2f0 to 712c911 Compare September 8, 2025 15:50
@mdrxy mdrxy enabled auto-merge (squash) September 8, 2025 15:54
@mdrxy mdrxy merged commit 01fdeed into langchain-ai:master Sep 8, 2025
14 checks passed
@cbornet cbornet deleted the ruff-core-preview-2 branch September 8, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the package `langchain-core` linting Linting, formatting, or typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants