fix: fix node-local-dns on cilium 1.16.5+

[rsafonseca]

fixes node-local-dns when BPF host networking is enabled on cilium 1.16.5+

The config change should automatically enable when cluster.spec.networking.cilium is specified
The config change should also enable when cluster.Spec.KubeDNS.NodeLocalDNS.CiliumBPFCompatibility is explicitly set to true, which is needed when users are managing cilium on their on via cluster.spec.networking.cni: {}

When applying onto an existing cluster, the nodes will need to be rolled out to recreate the node-local-dns pod, as well as update the dns resolver address that is being passed explicitly to kubelet. Once rollout of existing nodes is finished, it should be safe to upgrade cilium with BPF host networking enabled

fixes: #16597

[k8s-ci-robot]

Hi @rsafonseca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hakman]

/ok-to-test

[rsafonseca]

Looks like there's a valid test failure, will look into it in the morning :)

[hakman]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rsafonseca]

any blockers on this one @hakman ? :)

[rsafonseca]

kind ping on this @hakman

[rsafonseca]

/hold after some further testing, it seems to not be necessary on later versions of cilium 🤔

[hakman]

sorry for the late answer, maybe we can sync offline and see if there's any gap here left.
I also plan to update Cilium at some point, so this should be less annoying.