Skip to content

Conversation

keedya
Copy link
Contributor

@keedya keedya commented Sep 5, 2025

What type of PR is this?

bug

What this PR does / why we need it:

CoreWeave Provider; Correct the behavior when no nodegroups are available and nodepool has autoscaler disabled. It needs to return empty slice instead of an error. Currently it returns an error and the autoscaler marks itself unhealthy and restart.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

coreweave: don't return error when no nodegroups and autoscaler disabled

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @keedya. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2025
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am unfamiliar with the coreweave provider, but these changes seem reasonable to me.

@keedya keedya changed the title Bugfix update nodegoup Bugfix Coreweave Provider update nodegoup Sep 5, 2025
@keedya keedya changed the title Bugfix Coreweave Provider update nodegoup Bugfix CoreWeave Provider update nodegoup Sep 5, 2025
@keedya keedya changed the title Bugfix CoreWeave Provider update nodegoup CoreWeave Provider update nodegoup Sep 5, 2025
@keedya keedya changed the title CoreWeave Provider update nodegoup Update nodegoup for CoreWeave Provider Sep 5, 2025
@jackfrancis
Copy link
Contributor

/ok-to-test
/kind bug
/release-note-edit

coreweave: don't return error when no nodegroups and autoscaler disabled

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2025
@jackfrancis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, keedya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 54e1faf into kubernetes:master Sep 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/coreweave cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants