-
Notifications
You must be signed in to change notification settings - Fork 99
Bump Bazel version to 8.3.1, migrate to bzlmod and bump LLVM to latest #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful! I did not previously know how to put the llvm configuration part in MODULE.bazel, despite having done this migration on my main MLIR project (google/heir) already.
Can you also remove the bazel/import_llvm.bzl and related files that are no longer used?
If you rebase over main you should get the fixes to the github action |
Thanks will do. I also bump the LLVM version to latest but haven't really finished. Will absorb all your comments later |
Do you mind taking another look? Building seems work on my local machine. I also bump the LLVM to the latest version with some fixes in original code. hope I adopted all your suggestions. |
… latest file to get llvm commit hash
update LLVM submodule version used by cmake flow and update CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just waiting for CI to pass
Thanks! I think CI passed and really happy to contribute. 😃 |
Hi @j2kun
Thank you so much for your very helpful tutorial on MLIR. I really enjoy reading your words and really learn from you.
I found the bazel version is a little bit old, so I upgrade it to bazel 8.3.1 and migrate most of dependency to bzlmod.
I also bump LLVM version to latest as today (July 17, 2025)
Thank you again for providing such valuable tutorial