adding a new function for reconciling confirmations map in the connector interface #148
+113
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
force-pushed
the
expose-reconcile-confirmation-map
branch
from
7bc7bb8 to
07127ff
Compare
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
changed the title
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
EnriqueL8
reviewed
Sep 15, 2025
pkg/ffcapi/api.go
Outdated
| // the key of the map is the hash of the first block (tx block) that contains the transaction hash | ||
| // the value of the map is an array of blocks, the first block is the tx block | ||
| // the rest of the blocks are blocks inside the range of the target confirmation count | ||
| // gap is allowed between the tx block and the second block |
There was a problem hiding this comment.
shouldn't this just be an implementation detail from the connector?
There was a problem hiding this comment.
Could argue it's a connector implementation details. Will remove that from the comment
Chengxuan
commented
Sep 15, 2025
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing a method to allow confirmation map building using the in-memory canonical chain in the connector for efficient confirmation calculation of any given tx hash.
The new approach is similar to the existing confirmation manager, but with the following differences:
Additionally, there is a significant design difference when it comes to confirming a transaction that is inside a block no longer in the in-memory chain: the existing confirmation manager prioritizes confirmation details over confirmation latency and resource usage, whereas the new ReconcileConfirmationsForTransaction follows an instant confirmation approach.
More details in the firefly-evmconnect PR: hyperledger/firefly-evmconnect#174
A new confirmation map struct is introduced to capture all the potential confirmation queues (due to forking) of a single transaction hash. The confirmation map struct needs to be stored and passed back to the
ReconcileConfirmationsForTransactionby the consumer in order to persist confirmation queues that are no longer on the latest canonical chain.