Fix AddDispatchR when dispatchR and handlers are in same project and … #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove unnecessary cast from publish method
hasanxdev
reviewed
Jun 28, 2025
| @@ -36,9 +36,7 @@ public IAsyncEnumerable<TResponse> CreateStream<TRequest, TResponse>(IStreamRequ | |||
|
|
|||
| public async ValueTask Publish<TNotification>(TNotification request, CancellationToken cancellationToken) where TNotification : INotification | |||
| { | |||
| var notificationsInDi = serviceProvider.GetRequiredService<IEnumerable<INotificationHandler<TNotification>>>(); | |||
|
|
|||
| var notifications = Unsafe.As<INotificationHandler<TNotification>[]>(notificationsInDi); | |||
There was a problem hiding this comment.
Bro, this piece of code is necessary because when you use foreach on an IEnumerable, it causes boxing, which leads to memory allocation on the heap. With this approach, we avoid using foreach directly on IEnumerable.
More information: https://youtu.be/7w4ho3WzKss?list=PLGiSgN3ODieILgFQN1puu-ey9guWwnxGX&t=3280
hasanxdev
reviewed
Jun 28, 2025
| .Where(p => | ||
| var allTypes = configurationOptions.Assemblies.SelectMany(x => x.GetTypes()) | ||
| .Distinct() | ||
| .Where(type => type is { IsClass: true, IsAbstract: false }) |
There was a problem hiding this comment.
This is great, but I feel like we’ve drifted away from the original goal. We wanted to avoid picking up interfaces, but now we’re explicitly saying it has to be a class and not abstract.
I think if we just exclude interfaces and allow everything else, we could also support other types like structs.
What do you think?
|
Do we have any updates on this? @fsarab57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AddDispatchR when dispatchR and handlers are in same project and remove unnecessary cast from publish method