Skip to content

api: remove nullable from StatusOr value methods #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

api: remove nullable from StatusOr value methods #12338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b562e1
api: remove nullable from StatusOr value methods
panchenko Sep 7, 2025
bdaf027
Merge branch 'master' into StatusOr-remove-nullable-from-value
panchenko Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/src/main/java/io/grpc/StatusOr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private StatusOr(Status status, T value) {
}

/** Construct from a value. */
public static <T> StatusOr<T> fromValue(@Nullable T value) {
public static <T> StatusOr<T> fromValue(T value) {
StatusOr<T> result = new StatusOr<T>(null, value);
return result;
}
Expand All @@ -54,7 +54,7 @@ public boolean hasValue() {
* Returns the value if set or throws exception if there is no value set. This method is meant
* to be called after checking the return value of hasValue() first.
*/
public @Nullable T getValue() {
public T getValue() {
if (status != null) {
throw new IllegalStateException("No value present.");
}
Expand Down Expand Up @@ -105,6 +105,7 @@ public String toString() {
return stringHelper.toString();
}

@Nullable
private final Status status;
private final T value;
}